[styled-engine] Drop withComponent support #27780
Merged
+33
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
force-pushed
the
remove-withComponent
branch
2 times, most recently
from
6db4277 to
2543a42
Compare
9 tasks
oliviertassinari
force-pushed
the
remove-withComponent
branch
3 times, most recently
from
d58bdb6 to
e29ffb2
Compare
mnajdova
reviewed
Aug 16, 2021
|
|
||
| const ItemLink = styled(Item.withComponent(Link), { | ||
| const ItemLink = styled(Item, { |
There was a problem hiding this comment.
Suggested change
| const ItemLink = styled(Item, { | |
| const ItemLink = styled(({ component = Link, ...props }) => <Item component={component} {...props} />, { |
isn't this the equivalent?
There was a problem hiding this comment.
I imagine the equivalent is :
Suggested change
| const ItemLink = styled(Item, { | |
| const ItemLink = styled(({ component = Link, ...props }) => <Item as={component} {...props} />, { |
but there is already an as prop coming from the navigation that conflicts, e.g. as: '/api/accordion' so it doesn't work.
mnajdova
approved these changes
Aug 16, 2021
eps1lon
approved these changes
Aug 16, 2021
| tag: Tag, | ||
| ): StyledComponent<PropsOf<Tag>, StyleProps, Theme>; | ||
| } | ||
| ComponentSelector {} |
There was a problem hiding this comment.
Do we want to push it the extra mile with the tradeoff of @dimitropoulos in #20012 (comment)?
Suggested change
| ComponentSelector {} | |
| ComponentSelector { | |
| /** | |
| * Use the `as` prop instead. | |
| * It's not style destructive when using multiple layers of styled() calls. | |
| */ | |
| withComponent(tag: any): never; | |
| } |
There was a problem hiding this comment.
Actually, it doesn't work in this context. It would silence the missing support in TypeScript.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking changes
#27780) @oliviertassinariUse the
asprop instead. It's not style destructive when using multiple layers of styled() calls.Why?
https://styled-components.com/docs/api#withcomponent
https://goober.js.org/
I have noticed this in #27776.